1 files changed, 37 insertions, 26 deletions
diff --git a/ospf-to-leds.rsc b/ospf-to-leds.rsc
index 2dc8448..26f8aa3 100644
--- a/ospf-to-leds.rsc
+++ b/ospf-to-leds.rsc
@@ -1,38 +1,49 @@
 #!rsc by RouterOS
 # RouterOS script: ospf-to-leds
-# Copyright (c) 2020-2023 Christian Hesse <mail@eworm.de>
-# https://git.eworm.de/cgit/routeros-scripts/about/COPYING.md
+# Copyright (c) 2020-2025 Christian Hesse <mail@eworm.de>
+# https://rsc.eworm.de/COPYING.md
+#
+# requires RouterOS, version=7.15
 #
 # visualize ospf instance state via leds
-# https://git.eworm.de/cgit/routeros-scripts/about/doc/ospf-to-leds.md
+# https://rsc.eworm.de/doc/ospf-to-leds.md
 
-:local 0 "ospf-to-leds";
-:global GlobalFunctionsReady;
-:while ($GlobalFunctionsReady != true) do={ :delay 500ms; }
+:local ExitOK false;
+:onerror Err {
+  :global GlobalConfigReady; :global GlobalFunctionsReady;
+  :retry { :if ($GlobalConfigReady != true || $GlobalFunctionsReady != true) \
+      do={ :error ("Global config and/or functions not ready."); }; } delay=500ms max=50;
+  :local ScriptName [ :jobname ];
 
-:global LogPrintExit2;
-:global ParseKeyValueStore;
-:global ScriptLock;
+  :global LogPrint;
+  :global ParseKeyValueStore;
+  :global ScriptLock;
 
-$ScriptLock $0;
+  :if ([ $ScriptLock $ScriptName ] = false) do={
+    :set ExitOK true;
+    :error false;
+  }
 
-:foreach Instance in=[ /routing/ospf/instance/find where comment~"^ospf-to-leds," ] do={
-  :local InstanceVal [ /routing/ospf/instance/get $Instance ];
-  :local LED ([ $ParseKeyValueStore ($InstanceVal->"comment") ]->"leds");
-  :local LEDType [ /system/leds/get [ find where leds=$LED ] type ];
+  :foreach Instance in=[ /routing/ospf/instance/find where comment~"^ospf-to-leds," ] do={
+    :local InstanceVal [ /routing/ospf/instance/get $Instance ];
+    :local LED ([ $ParseKeyValueStore ($InstanceVal->"comment") ]->"leds");
+    :local LEDType [ /system/leds/get [ find where leds=$LED ] type ];
 
-  :local NeighborCount 0;
-  :foreach Area in=[ /routing/ospf/area/find where instance=($InstanceVal->"name") ] do={
-    :local AreaName [ /routing/ospf/area/get $Area name ];
-    :set NeighborCount ($NeighborCount + [ :len [ /routing/ospf/neighbor/find where area=$AreaName ] ]);
-  }
+    :local NeighborCount 0;
+    :foreach Area in=[ /routing/ospf/area/find where instance=($InstanceVal->"name") ] do={
+      :local AreaName [ /routing/ospf/area/get $Area name ];
+      :set NeighborCount ($NeighborCount + [ :len [ /routing/ospf/neighbor/find where area=$AreaName ] ]);
+    }
 
-  :if ($NeighborCount > 0 && $LEDType = "off") do={
-    $LogPrintExit2 info $0 ("OSPF instance " . $InstanceVal->"name" . " has " . $NeighborCount . " neighbors, led on!") false;
-    /system/leds/set type=on [ find where leds=$LED ];
-  }
-  :if ($NeighborCount = 0 && $LEDType = "on") do={
-    $LogPrintExit2 info $0 ("OSPF instance " . $InstanceVal->"name" . " has no neighbors, led off!") false;
-    /system/leds/set type=off [ find where leds=$LED ];
+    :if ($NeighborCount > 0 && $LEDType = "off") do={
+      $LogPrint info $ScriptName ("OSPF instance " . $InstanceVal->"name" . " has " . $NeighborCount . " neighbors, led on!");
+      /system/leds/set type=on [ find where leds=$LED ];
+    }
+    :if ($NeighborCount = 0 && $LEDType = "on") do={
+      $LogPrint info $ScriptName ("OSPF instance " . $InstanceVal->"name" . " has no neighbors, led off!");
+      /system/leds/set type=off [ find where leds=$LED ];
+    }
   }
+} do={
+  :global ExitError; $ExitError $ExitOK [ :jobname ] $Err;
 }