1 files changed, 69 insertions, 49 deletions

diff --git a/mode-button.rsc b/mode-button.rsc
index 87e8740..edc5f40 100644
--- a/mode-button.rsc
+++ b/mode-button.rsc
@@ -1,76 +1,96 @@
 #!rsc by RouterOS
 # RouterOS script: mode-button
-# Copyright (c) 2018-2023 Christian Hesse <mail@eworm.de>
-# https://git.eworm.de/cgit/routeros-scripts/about/COPYING.md
+# Copyright (c) 2018-2025 Christian Hesse <mail@eworm.de>
+# https://rsc.eworm.de/COPYING.md
+#
+# requires RouterOS, version=7.15
+# requires device-mode, scheduler
 #
 # act on multiple mode and reset button presses
-# https://git.eworm.de/cgit/routeros-scripts/about/doc/mode-button.md
+# https://rsc.eworm.de/doc/mode-button.md
 
-:local 0 "mode-button";
 :global GlobalFunctionsReady;
 :while ($GlobalFunctionsReady != true) do={ :delay 500ms; }
 
-:global ModeButton;
+:local ExitOK false;
+:do {
+  :local ScriptName [ :jobname ];
+
+  :global ModeButton;
 
-:global LogPrintExit2;
+  :global LogPrint;
 
-:set ($ModeButton->"count") ($ModeButton->"count" + 1);
+  :set ($ModeButton->"count") ($ModeButton->"count" + 1);
 
-:local Scheduler [ /system/scheduler/find where name="\$ModeButtonScheduler" ];
+  :local Scheduler [ /system/scheduler/find where name="_ModeButtonScheduler" ];
 
-:if ([ :len $Scheduler ] = 0) do={
-  $LogPrintExit2 info $0 ("Creating scheduler \$ModeButtonScheduler, counting presses...") false;
-  :global ModeButtonScheduler do={
-    :global ModeButton;
+  :if ([ :len $Scheduler ] = 0) do={
+    $LogPrint info $ScriptName ("Creating scheduler _ModeButtonScheduler, counting presses...");
+    :global ModeButtonScheduler do={ :do {
+      :local FuncName $0;
 
-    :global LogPrintExit2;
-    :global ModeButtonScheduler;
-    :global ValidateSyntax;
+      :global ModeButton;
 
-    :local LEDInvert do={
-      :global ModeButtonLED;
+      :global LogPrint;
+      :global ModeButtonScheduler;
+      :global ValidateSyntax;
 
-      :global IfThenElse;
+      :local LEDInvert do={
+        :global ModeButtonLED;
 
-      :local LED [ /system/leds/find where leds=$ModeButtonLED type~"^(on|off)\$" interface=[] ];
-      :if ([ :len $LED ] = 0) do={
-        :return false;
+        :global IfThenElse;
+
+        :local LED [ /system/leds/find where leds=$ModeButtonLED \
+            !disabled type~"^(on|off)\$" interface=[] ];
+        :if ([ :len $LED ] = 0) do={
+          :return false;
+        }
+        /system/leds/set type=[ $IfThenElse ([ get $LED type ] = "on") "off" "on" ] $LED;
       }
-      /system/leds/set type=[ $IfThenElse ([ get $LED type ] = "on") "off" "on" ] $LED;
-    }
 
-    :local Count ($ModeButton->"count");
-    :local Code ($ModeButton->[ :tostr $Count ]);
+      :local Count ($ModeButton->"count");
+      :local Code ($ModeButton->[ :tostr $Count ]);
 
-    :set ($ModeButton->"count") 0;
-    :set ModeButtonScheduler;
-    /system/scheduler/remove [ find where name=$0 ];
+      :set ($ModeButton->"count") 0;
+      :set ModeButtonScheduler;
+      /system/scheduler/remove [ find where name="_ModeButtonScheduler" ];
 
-    :if ([ :len $Code ] > 0) do={
-      :if ([ $ValidateSyntax $Code ] = true) do={
-        $LogPrintExit2 info $0 ("Acting on " . $Count . " mode-button presses: " . $Code) false;
+      :if ([ :len $Code ] > 0) do={
+        :if ([ $ValidateSyntax $Code ] = true) do={
+          $LogPrint info $FuncName ("Acting on " . $Count . " mode-button presses: " . $Code);
 
-        :for I from=1 to=$Count do={
-          $LEDInvert;
-          :if ([ /system/routerboard/settings/get silent-boot ] = false) do={
-            :beep length=200ms;
+          :for I from=1 to=$Count do={
+            $LEDInvert;
+            :if ([ /system/routerboard/settings/get silent-boot ] = false) do={
+              :beep length=200ms;
+            }
+            :delay 200ms;
+            $LEDInvert;
+            :delay 200ms;
           }
-          :delay 200ms;
-          $LEDInvert;
-          :delay 200ms;
-        }
 
-        [ :parse $Code ];
+          :do {
+            [ :parse $Code ];
+          } on-error={
+            $LogPrint warning $FuncName \
+                ("The code for " . $Count . " mode-button presses failed with runtime error!");
+          }
+        } else={
+          $LogPrint warning $FuncName \
+              ("The code for " . $Count . " mode-button presses failed syntax validation!");
+        }
       } else={
-        $LogPrintExit2 warning $0 ("The code for " . $Count . " mode-button presses failed syntax validation!") false;
+        $LogPrint info $FuncName ("No action defined for " . $Count . " mode-button presses.");
       }
-    } else={
-      $LogPrintExit2 info $0 ("No action defined for " . $Count . " mode-button presses.") false;
-    }
+    } on-error={
+      :global ExitError; $ExitError false $0;
+    } }
+    /system/scheduler/add name="_ModeButtonScheduler" \
+        on-event=":global ModeButtonScheduler; \$ModeButtonScheduler;" interval=3s;
+  } else={
+    $LogPrint debug $ScriptName ("Updating scheduler _ModeButtonScheduler...");
+    /system/scheduler/set $Scheduler start-time=[ /system/clock/get time ];
   }
-  /system/scheduler/add name="\$ModeButtonScheduler" \
-      on-event=":global ModeButtonScheduler; \$ModeButtonScheduler;" interval=3s;
-} else={
-  $LogPrintExit2 debug $0 ("Updating scheduler \$ModeButtonScheduler...") false;
-  /system/scheduler/set $Scheduler start-time=[ /system/clock/get time ];
+} on-error={
+  :global ExitError; $ExitError $ExitOK [ :jobname ];
 }