1 files changed, 69 insertions, 42 deletions

diff --git a/global-functions.rsc b/global-functions.rsc
index a2dd279..a2ec833 100644
--- a/global-functions.rsc
+++ b/global-functions.rsc
@@ -2,12 +2,13 @@
 # RouterOS script: global-functions
 # Copyright (c) 2013-2025 Christian Hesse <mail@eworm.de>
 #                         Michael Gisbers <michael@gisbers.de>
-# https://git.eworm.de/cgit/routeros-scripts/about/COPYING.md
+# https://rsc.eworm.de/COPYING.md
 #
 # requires RouterOS, version=7.14
+# requires device-mode, fetch, scheduler
 #
 # global functions
-# https://git.eworm.de/cgit/routeros-scripts/about/
+# https://rsc.eworm.de/
 
 :local ScriptName [ :jobname ];
 
@@ -1071,6 +1072,7 @@
   :local ExpectedConfigVersionBefore $ExpectedConfigVersion;
   :local ReloadGlobalFunctions false;
   :local ReloadGlobalConfig false;
+  :local DeviceMode [ /system/device-mode/get ];
 
   :foreach Script in=[ /system/script/find where source~"^#!rsc by RouterOS\r?\n" ] do={
     :local ScriptVal [ /system/script/get $Script ];
@@ -1107,40 +1109,59 @@
       }
     }
 
-    :if ([ :len $SourceNew ] > 0) do={
+    :do {
+      :if ([ :len $SourceNew ] = 0) do={
+        $LogPrint debug $0 ("No update for script '" . $ScriptVal->"name" . "'.");
+        :error false;
+      }
+
       :local SourceCRLF [ :tocrlf $SourceNew ];
-      :if ($SourceNew != $ScriptVal->"source" && $SourceCRLF != $ScriptVal->"source") do={
-        :if ([ :pick $SourceNew 0 18 ] = "#!rsc by RouterOS\n") do={
-          :local Required ([ $ParseKeyValueStore [ $Grep $SourceNew ("\23 requires RouterOS, ") ] ]->"version");
-          :if ([ $RequiredRouterOS $0 [ $EitherOr $Required "0.0" ] false ] = true) do={
-            :if ([ $ValidateSyntax $SourceNew ] = true) do={
-              $LogPrint info $0 ("Updating script: " . $ScriptVal->"name");
-              /system/script/set owner=($ScriptVal->"name") \
-                  source=[ $IfThenElse ($ScriptUpdatesCRLF = true) $SourceCRLF $SourceNew ] $Script;
-              :if ($ScriptVal->"name" = "global-config") do={
-                :set ReloadGlobalConfig true;
-              }
-              :if ($ScriptVal->"name" = "global-functions" || $ScriptVal->"name" ~ ("^mod/.")) do={
-                :set ReloadGlobalFunctions true;
-              }
-            } else={
-              $LogPrint warning $0 ("Syntax validation for script '" . $ScriptVal->"name" . \
-                "' failed! Ignoring!");
-            }
-          } else={
-            $LogPrintOnce warning $0 ("The script '" . $ScriptVal->"name" . "' requires RouterOS " . \
-              $Required . ", which is not met by your installation. Ignoring!");
-          }
-        } else={
-          $LogPrint warning $0 ("Looks like new script '" . $ScriptVal->"name" . \
+      :if ($SourceNew = $ScriptVal->"source" || $SourceCRLF = $ScriptVal->"source") do={
+        $LogPrint debug $0 ("Script '" .  $ScriptVal->"name" . "' did not change.");
+        :error false;
+      }
+
+      :if ([ :pick $SourceNew 0 18 ] != "#!rsc by RouterOS\n") do={
+        $LogPrint warning $0 ("Looks like new script '" . $ScriptVal->"name" . \
             "' is not valid (missing shebang). Ignoring!");
+        :error false;
+      }
+
+      :local RequiredROS ([ $ParseKeyValueStore [ $Grep $SourceNew ("\23 requires RouterOS, ") ] ]->"version");
+      :if ([ $RequiredRouterOS $0 [ $EitherOr $RequiredROS "0.0" ] false ] = false) do={
+        $LogPrintOnce warning $0 ("The script '" . $ScriptVal->"name" . "' requires RouterOS " . \
+            $RequiredROS . ", which is not met by your installation. Ignoring!");
+        :error false;
+      }
+
+      :local RequiredDM [ $ParseKeyValueStore [ $Grep $SourceNew ("\23 requires device-mode, ") ] ];
+      :local MissingDM ({});
+      :foreach Feature,Value in=$RequiredDM do={
+        :if ([ :typeof ($DeviceMode->$Feature) ] = "bool" && ($DeviceMode->$Feature) = false) do={
+          :set MissingDM ($MissingDM, $Feature);
         }
-      } else={
-        $LogPrint debug $0 ("Script '" .  $ScriptVal->"name" . "' did not change.");
       }
-    } else={
-      $LogPrint debug $0 ("No update for script '" . $ScriptVal->"name" . "'.");
-    }
+      :if ([ :len $MissingDM ] > 0) do={
+        $LogPrintOnce warning $0 ("The script '" . $ScriptVal->"name" . "' requires disabled " . \
+            "device-mode features (" . [ :tostr $MissingDM ] . "). Ignoring!");
+        :error false;
+      }
+
+      :if ([ $ValidateSyntax $SourceNew ] = false) do={
+        $LogPrint warning $0 ("Syntax validation for script '" . $ScriptVal->"name" . "' failed! Ignoring!");
+        :error false;
+      }
+
+      $LogPrint info $0 ("Updating script: " . $ScriptVal->"name");
+      /system/script/set owner=($ScriptVal->"name") \
+          source=[ $IfThenElse ($ScriptUpdatesCRLF = true) $SourceCRLF $SourceNew ] $Script;
+      :if ($ScriptVal->"name" = "global-config") do={
+        :set ReloadGlobalConfig true;
+      }
+      :if ($ScriptVal->"name" = "global-functions" || $ScriptVal->"name" ~ ("^mod/.")) do={
+        :set ReloadGlobalFunctions true;
+      }
+    } on-error={ }
   }
 
   :if ($ReloadGlobalFunctions = true) do={
@@ -1200,18 +1221,24 @@
     :if ([ :len $GlobalConfigMigration ] > 0) do={
       :for I from=($ExpectedConfigVersionBefore + 1) to=$ExpectedConfigVersion do={
         :local Migration ($GlobalConfigMigration->[ :tostr $I ]);
-        :if ([ :typeof $Migration ] = "str") do={
-          :if ([ $ValidateSyntax $Migration ] = true) do={
-            $LogPrint info $0 ("Applying migration for change " . $I . ": " . $Migration);
-            :do {
-              [ :parse $Migration ];
-            } on-error={
-              $LogPrint warning $0 ("Migration code for change " . $I . " failed to run!");
-            }
-          } else={
+        :do {
+          :if ([ :typeof $Migration ] != "str") do={
+            $LogPrint debug $0 ("Migration code for change " . $I . " is not available.");
+            :error false;
+          }
+
+          :if ([ $ValidateSyntax $Migration ] = false) do={
             $LogPrint warning $0 ("Migration code for change " . $I . " failed syntax validation!");
+            :error false;
           }
-        }
+
+          $LogPrint info $0 ("Applying migration for change " . $I . ": " . $Migration);
+          :do {
+            [ :parse $Migration ];
+          } on-error={
+            $LogPrint warning $0 ("Migration code for change " . $I . " failed to run!");
+          }
+        } on-error={ }
       }
     }