From 870f00bb36f5af3088344371764da48bbde9651a Mon Sep 17 00:00:00 2001
From: Christian Hesse <mail@eworm.de>
Date: Thu, 3 Jan 2019 17:45:43 +0100
Subject: global: variable names are CamelCase

            ___  _         ___     __
           / _ )(_)__ _   / _/__ _/ /_
          / _  / / _ `/  / _/ _ `/ __/
         /____/_/\_, /  /_/ \_,_/\__/
 _       __     /___/       _             __
| |     / /___ __________  (_)___  ____ _/ /
| | /| / / __ `/ ___/ __ \/ / __ \/ __ `/ /
| |/ |/ / /_/ / /  / / / / / / / / /_/ /_/
|__/|__/\__,_/_/  /_/ /_/_/_/ /_/\__, (_)
                                /____/

RouterOS has some odd behavior when it comes to variable names. Let's
have a look at the interfaces:

[admin@MikroTik] > / interface print where name=en1
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598

That looks ok. Now we use a script:

{ :local interface "en1";
  / interface print where name=$interface; }

And the result...

[admin@MikroTik] > { :local interface "en1";
{...   / interface print where name=$interface; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598

... still looks ok.
We make a little modification to the script:

{ :local name "en1";
  / interface print where name=$name; }

And the result:

[admin@MikroTik] > { :local name "en1";
{...   / interface print where name=$name; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598
 1   S en2                                 ether            1500  1598
 2   S en3                                 ether            1500  1598
 3   S en4                                 ether            1500  1598
 4   S en5                                 ether            1500  1598
 5  R  br-local                            bridge           1500  1598

Ups! The filter has no effect!
That happens whenever the variable name ($name) matches the property
name (name=).

And another modification:

{ :local type "en1";
  / interface print where name=$type; }

And the result:

[admin@MikroTik] > { :local type "en1";
{...   / interface print where name=$type; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU

Ups! Nothing?
Even if the variable name ($type) matches whatever property name (type=)
things go wrong.

The answer from MikroTik support (in Ticket#2019010222000454):

> This is how scripting works in RouterOS and we will not fix it.

To get around this we use variable names in CamelCase. Let's hope
Mikrotik never ever introduces property names in CamelCase...

*fingers crossed*
---
 unattended-lte-firmware-upgrade | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

(limited to 'unattended-lte-firmware-upgrade')

diff --git a/unattended-lte-firmware-upgrade b/unattended-lte-firmware-upgrade
index 3570c57..9a717e3 100644
--- a/unattended-lte-firmware-upgrade
+++ b/unattended-lte-firmware-upgrade
@@ -4,26 +4,26 @@
 #
 # schedule unattended lte firmware upgrade
 
-:foreach interface in=[ / interface lte find ] do={
-  :local firmware;
-  :local intname [ / interface lte get $interface name ];
+:foreach Interface in=[ / interface lte find ] do={
+  :local Firmware;
+  :local IntName [ / interface lte get $Interface name ];
   do {
-    :set firmware [ / interface lte firmware-upgrade $interface once as-value ];
+    :set Firmware [ / interface lte firmware-upgrade $Interface once as-value ];
     # strip the extra line break (TODO: remove when fixed upstream)
-    :set ($firmware->"latest") [ :pick ($firmware->"latest") 0 [ :find ($firmware->"latest") "\n" ] ];
+    :set ($Firmware->"latest") [ :pick ($Firmware->"latest") 0 [ :find ($Firmware->"latest") "\n" ] ];
   } on-error={
-    :log debug ("Could not get latest LTE firmware version for interface " . $intname . ".");
+    :log debug ("Could not get latest LTE firmware version for interface " . $IntName . ".");
   }
 
-  :if (($firmware->"installed") != ($firmware->"latest")) do={
-    :log info ("Scheduling LTE firmware upgrade for interface " . $intname . ".");
-    / system script add name=($intname . "-firmware-upgrade") source=("# unattended-lte-firmware-upgrade\n" . \
-       "/ system scheduler remove " . $intname . "-firmware-upgrade;\n" . \
-       "/ system script remove " . $intname . "-firmware-upgrade;\n" . \
-       "/ interface lte firmware-upgrade " . $intname . " upgrade=yes;\n" . \
+  :if (($Firmware->"installed") != ($Firmware->"latest")) do={
+    :log info ("Scheduling LTE firmware upgrade for interface " . $IntName . ".");
+    / system script add name=($IntName . "-firmware-upgrade") source=("# unattended-lte-firmware-upgrade\n" . \
+       "/ system scheduler remove " . $IntName . "-firmware-upgrade;\n" . \
+       "/ system script remove " . $IntName . "-firmware-upgrade;\n" . \
+       "/ interface lte firmware-upgrade " . $IntName . " upgrade=yes;\n" . \
        ":log info (\"LTE firmware upgrade finished, waiting for installation before reset.\");\n" . \
        ":delay 150s;\n" . \
-       "/ interface lte at-chat " . $intname . " input=\"AT+RESET\";");
-    / system scheduler add name=($intname . "-firmware-upgrade") on-event=($intname . "-firmware-upgrade") interval=1m;
+       "/ interface lte at-chat " . $IntName . " input=\"AT+RESET\";");
+    / system scheduler add name=($IntName . "-firmware-upgrade") on-event=($IntName . "-firmware-upgrade") interval=1m;
   }
 }
-- 
cgit v1.2.3-54-g00ecf