From 870f00bb36f5af3088344371764da48bbde9651a Mon Sep 17 00:00:00 2001
From: Christian Hesse <mail@eworm.de>
Date: Thu, 3 Jan 2019 17:45:43 +0100
Subject: global: variable names are CamelCase

            ___  _         ___     __
           / _ )(_)__ _   / _/__ _/ /_
          / _  / / _ `/  / _/ _ `/ __/
         /____/_/\_, /  /_/ \_,_/\__/
 _       __     /___/       _             __
| |     / /___ __________  (_)___  ____ _/ /
| | /| / / __ `/ ___/ __ \/ / __ \/ __ `/ /
| |/ |/ / /_/ / /  / / / / / / / / /_/ /_/
|__/|__/\__,_/_/  /_/ /_/_/_/ /_/\__, (_)
                                /____/

RouterOS has some odd behavior when it comes to variable names. Let's
have a look at the interfaces:

[admin@MikroTik] > / interface print where name=en1
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598

That looks ok. Now we use a script:

{ :local interface "en1";
  / interface print where name=$interface; }

And the result...

[admin@MikroTik] > { :local interface "en1";
{...   / interface print where name=$interface; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598

... still looks ok.
We make a little modification to the script:

{ :local name "en1";
  / interface print where name=$name; }

And the result:

[admin@MikroTik] > { :local name "en1";
{...   / interface print where name=$name; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598
 1   S en2                                 ether            1500  1598
 2   S en3                                 ether            1500  1598
 3   S en4                                 ether            1500  1598
 4   S en5                                 ether            1500  1598
 5  R  br-local                            bridge           1500  1598

Ups! The filter has no effect!
That happens whenever the variable name ($name) matches the property
name (name=).

And another modification:

{ :local type "en1";
  / interface print where name=$type; }

And the result:

[admin@MikroTik] > { :local type "en1";
{...   / interface print where name=$type; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU

Ups! Nothing?
Even if the variable name ($type) matches whatever property name (type=)
things go wrong.

The answer from MikroTik support (in Ticket#2019010222000454):

> This is how scripting works in RouterOS and we will not fix it.

To get around this we use variable names in CamelCase. Let's hope
Mikrotik never ever introduces property names in CamelCase...

*fingers crossed*
---
 sms-forward | 30 +++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)

(limited to 'sms-forward')

diff --git a/sms-forward b/sms-forward
index d94f0c3..f22949f 100644
--- a/sms-forward
+++ b/sms-forward
@@ -4,7 +4,7 @@
 #
 # forward SMS to e-mail
 
-:global "identity";
+:global Identity;
 
 :global SendNotification;
 
@@ -13,25 +13,25 @@
   :error "Mail server is not up.";
 }
 
-:local allowed [ / tool sms get allowed-number ];
-:local secret [ / tool sms get secret ];
+:local Allowed [ / tool sms get allowed-number ];
+:local Secret [ / tool sms get secret ];
 
 # forward SMS in a loop
-:foreach sms in=[ / tool sms inbox find ] do={
-  :local message   [ / tool sms inbox get $sms message ];
-  :local phone     [ / tool sms inbox get $sms phone ];
-  :local timestamp [ / tool sms inbox get $sms timestamp ];
-  :local type      [ / tool sms inbox get $sms type ];
+:foreach Sms in=[ / tool sms inbox find ] do={
+  :local Message   [ / tool sms inbox get $Sms message ];
+  :local Phone     [ / tool sms inbox get $Sms phone ];
+  :local TimeStamp [ / tool sms inbox get $Sms timestamp ];
+  :local Type      [ / tool sms inbox get $Sms type ];
 
-  :if ($phone = $allowed && message~("^:cmd " . $secret . " script ")) do={
+  :if ($Phone = $Allowed && $Message~("^:cmd " . $Secret . " script ")) do={
     :log debug "Ignoring SMS, which starts a script.";
   } else={
     $SendNotification ("SMS Forwarding") \
-      ("A message was received by " . $identity . ":\n\n" . \
-        "Phone:     " . $phone . "\n" . \
-        "Timestamp: " . $timestamp . "\n" . \
-        "Type:      " . $type . "\n\n" . \
-        "Message:\n" .  $message);
-    / tool sms inbox remove $sms;
+      ("A message was received by " . $Identity . ":\n\n" . \
+        "Phone:     " . $Phone . "\n" . \
+        "Timestamp: " . $TimeStamp . "\n" . \
+        "Type:      " . $Type . "\n\n" . \
+        "Message:\n" .  $Message);
+    / tool sms inbox remove $Sms;
   }
 }
-- 
cgit v1.2.3-54-g00ecf