From 6d9eb99e08fb0a1ac8dc03213edfd5f590655ee4 Mon Sep 17 00:00:00 2001
From: Christian Hesse <mail@eworm.de>
Date: Fri, 16 Oct 2020 22:51:51 +0200
Subject: check-health: add deviation on temperature recovery threshold

This helps against notification flooding.
---
 check-health | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

(limited to 'check-health')

diff --git a/check-health b/check-health
index c27178d..ff4cf36 100644
--- a/check-health
+++ b/check-health
@@ -8,6 +8,8 @@
 
 :global CheckHealthLast;
 :global CheckHealthTemperature;
+:global CheckHealthTemperatureDeviation;
+:global CheckHealthTemperatureNotified;
 :global CheckHealthVoltagePercent;
 :global Identity;
 
@@ -26,6 +28,10 @@
   $LogPrintExit error ("Your device does not provide any health values.") true;
 }
 
+:if ([ :typeof $CheckHealthTemperatureNotified ] != "array") do={
+  :set CheckHealthTemperatureNotified [ :toarray "" ];
+}
+
 :foreach Voltage in={ "battery"; "psu1-voltage"; "psu2-voltage"; "voltage" } do={
   :if ([ :typeof ($CheckHealthLast->$Voltage) ] = "num" && \
        [ :typeof ($CheckHealthCurrent->$Voltage) ] = "num") do={
@@ -56,23 +62,24 @@
 }
 
 :foreach Temperature in={ "temperature"; "cpu-temperature"; "board-temperature1"; "board-temperature2" } do={
-  :if ([ :typeof ($CheckHealthLast->$Temperature) ] = "num" && \
-       [ :typeof ($CheckHealthCurrent->$Temperature) ] = "num") do={
+  :if ([ :typeof ($CheckHealthCurrent->$Temperature) ] = "num") do={
     :if ([ :typeof ($CheckHealthTemperature->$Temperature) ] != "num" ) do={
       $LogPrintExit warning ("No threshold given for " . $Temperature . ", assuming 50C.") false;
       :set ($CheckHealthTemperature->$Temperature) 50;
     }
-    :if ($CheckHealthLast->$Temperature <= $CheckHealthTemperature->$Temperature && \
-         $CheckHealthCurrent->$Temperature > $CheckHealthTemperature->$Temperature) do={
+    :if ($CheckHealthCurrent->$Temperature > $CheckHealthTemperature->$Temperature && \
+         $CheckHealthTemperatureNotified->$Temperature != true) do={
       $SendNotification ([ $SymbolForNotification "fire" ] . "Health warning: " . $Temperature) \
           ("The " . $Temperature . " on " . $Identity . " is above threshold: " .  \
           $CheckHealthCurrent->$Temperature . "\C2\B0" . "C");
+      :set ($CheckHealthTemperatureNotified->$Temperature) true;
     }
-    :if ($CheckHealthLast->$Temperature > $CheckHealthTemperature->$Temperature && \
-         $CheckHealthCurrent->$Temperature <= $CheckHealthTemperature->$Temperature) do={
+    :if ($CheckHealthCurrent->$Temperature <= ($CheckHealthTemperature->$Temperature - $CheckHealthTemperatureDeviation) && \
+         $CheckHealthTemperatureNotified->$Temperature = true) do={
       $SendNotification ([ $SymbolForNotification "white-heavy-check-mark" ] . "Health recovery: " . $Temperature) \
           ("The " . $Temperature . " on " . $Identity . " dropped below threshold: " .  \
           $CheckHealthCurrent->$Temperature . "\C2\B0" . "C");
+      :set ($CheckHealthTemperatureNotified->$Temperature) false;
     }
   }
 }
-- 
cgit v1.2.3-54-g00ecf