From 721b6c783bb492cf850874d5608214293275b4fc Mon Sep 17 00:00:00 2001
From: Christian Hesse <mail@eworm.de>
Date: Mon, 4 Mar 2024 13:48:01 +0100
Subject: sms-action: move code into function

---
 sms-action.rsc | 34 +++++++++++++++++++---------------
 1 file changed, 19 insertions(+), 15 deletions(-)

diff --git a/sms-action.rsc b/sms-action.rsc
index 49b6cd5..b78a2b2 100644
--- a/sms-action.rsc
+++ b/sms-action.rsc
@@ -8,26 +8,30 @@
 # run action on received SMS
 # https://git.eworm.de/cgit/routeros-scripts/about/doc/sms-action.md
 
-:local 0 [ :jobname ];
 :global GlobalFunctionsReady;
 :while ($GlobalFunctionsReady != true) do={ :delay 500ms; }
 
-:global SmsAction;
+:local Main do={
+  :local ScriptName [ :tostr $1 ];
+  :local Action     [ :tostr $2 ];
 
-:global LogPrintExit2;
-:global ValidateSyntax;
+  :global SmsAction;
 
-:local Action $action;
+  :global LogPrintExit2;
+  :global ValidateSyntax;
 
-:if ([ :typeof $Action ] = "nothing") do={
-  $LogPrintExit2 error $0 ("This script is supposed to run from SMS hook with action=...") true;
-}
+  :if ([ :len $Action ] = 0) do={
+    $LogPrintExit2 error $ScriptName ("This script is supposed to run from SMS hook with action=...") true;
+  }
 
-:local Code ($SmsAction->$Action);
-:if ([ $ValidateSyntax $Code ] = true) do={
-  :log info ("Acting on SMS action '" . $Action . "': " . $Code);
-  :delay 1s;
-  [ :parse $Code ];
-} else={
-  $LogPrintExit2 warning $0 ("The code for action '" . $Action . "' failed syntax validation!") false;
+  :local Code ($SmsAction->$Action);
+  :if ([ $ValidateSyntax $Code ] = true) do={
+    :log info ("Acting on SMS action '" . $Action . "': " . $Code);
+    :delay 1s;
+    [ :parse $Code ];
+  } else={
+    $LogPrintExit2 warning $ScriptName ("The code for action '" . $Action . "' failed syntax validation!") false;
+  }
 }
+
+$Main [ :jobname ] $action;
-- 
cgit v1.2.3-70-g09d2