| Age | Commit message (Expand) | Author | Files | Lines |
|---|
| 2021-07-08 | lease-script: modify the tag |  Christian Hesse | 1 | -1/+1 |
| 2021-07-01 | lease-script: do not run too many instances of scripts•••Every instance of the scripts does all the work. If one script is running
and a second script is waiting we do not have to start a third one.
| Christian Hesse | 1 | -5/+7 |
| 2021-07-01 | lease-script: drop the delay magic...•••... as this should be handled by $ScriptLock in lease scripts now.
| Christian Hesse | 1 | -6/+0 |
| 2021-06-24 | lease-script: do not run in parallel on simultaneous deassign | Christian Hesse | 1 | -2/+5 |
| 2021-06-23 | lease-script: use $LogPrintExit2•••This will never print to terminal, nevertheless we want proper
log with script name in prefix.
| Christian Hesse | 1 | -4/+4 |
| 2021-06-23 | lease-script: add error handling | Christian Hesse | 1 | -2/+6 |
| 2021-06-23 | lease-script: use 'provides' to find lease scripts | Christian Hesse | 1 | -25/+7 |
| 2021-02-24 | global: give script or function name in log messages | Christian Hesse | 1 | -2/+3 |
| 2021-02-18 | global: drop script 'global-wait'•••All scripts wait for the global functions on their own now.
change-44 | Christian Hesse | 1 | -0/+3 |
| 2021-01-01 | update copyright for 2021 | Christian Hesse | 1 | -1/+1 |
| 2020-09-20 | lease-script: give correct hint in message | Christian Hesse | 1 | -1/+1 |
| 2020-09-18 | extend magic pattern with "by RouterOS"•••This matches the string included in export.
| Christian Hesse | 1 | -1/+1 |
| 2020-08-26 | [ ... print count-only ...] -> [ :len [ ... find ... ] ]•••Using 'print count-only' always prints a number to terminal, even if the
value is evaluated in a condition or assigned to a variable. This can be
quite annoying. Behavior will not chance (SUP-25503), so replacing the
code...
| Christian Hesse | 1 | -1/+1 |
| 2020-06-19 | explicitly name the license•••Copyright (C) 2013-2020 Christian Hesse <mail@eworm.de>
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
https://www.gnu.org/licenses/#GPL
https://www.gnu.org/licenses/gpl.html
https://www.gnu.org/licenses/gpl.md
| Christian Hesse | 1 | -0/+1 |
| 2020-03-27 | add doc/lease-script.md | Christian Hesse | 1 | -0/+1 |
| 2020-02-26 | global-functions: merge $LogAnd{Error,Put} to $LogPrintExit ...•••... and fix logging.
Logging with severity from variable (:log $severity ...) is not
possible, this is considered a syntax error. Also the 'workaround' with
parsing code failed with missing message in log.
The reliable code is a lot longer, so merge the two functions to save a
lot of duplicate code.
| Christian Hesse | 1 | -2/+2 |
| 2020-02-26 | global-functions: $LogAndError: add severity | Christian Hesse | 1 | -1/+1 |
| 2020-02-26 | lease-script: use $LogAndError | Christian Hesse | 1 | -2/+3 |
| 2020-01-01 | update copyright for 2020 | Christian Hesse | 1 | -1/+1 |
| 2019-07-05 | lease-script: give hint about mis-usage | Christian Hesse | 1 | -0/+8 |
| 2019-01-15 | lease-script: split scripts for de/assign, add debug log | Christian Hesse | 1 | -4/+18 |
| 2019-01-04 | global: variable names are CamelCase••• ___ _ ___ __
/ _ )(_)__ _ / _/__ _/ /_
/ _ / / _ `/ / _/ _ `/ __/
/____/_/\_, / /_/ \_,_/\__/
_ __ /___/ _ __
| | / /___ __________ (_)___ ____ _/ /
| | /| / / __ `/ ___/ __ \/ / __ \/ __ `/ /
| |/ |/ / /_/ / / / / / / / / / / /_/ /_/
|__/|__/\__,_/_/ /_/ /_/_/_/ /_/\__, (_)
/____/
RouterOS has some odd behavior when it comes to variable names. Let's
have a look at the interfaces:
[admin@MikroTik] > / interface print where name=en1
Flags: D - dynamic, X - disabled, R - running, S - slave
# NAME TYPE ACTUAL-MTU L2MTU
0 RS en1 ether 1500 1598
That looks ok. Now we use a script:
{ :local interface "en1";
/ interface print where name=$interface; }
And the result...
[admin@MikroTik] > { :local interface "en1";
{... / interface print where name=$interface; }
Flags: D - dynamic, X - disabled, R - running, S - slave
# NAME TYPE ACTUAL-MTU L2MTU
0 RS en1 ether 1500 1598
... still looks ok.
We make a little modification to the script:
{ :local name "en1";
/ interface print where name=$name; }
And the result:
[admin@MikroTik] > { :local name "en1";
{... / interface print where name=$name; }
Flags: D - dynamic, X - disabled, R - running, S - slave
# NAME TYPE ACTUAL-MTU L2MTU
0 RS en1 ether 1500 1598
1 S en2 ether 1500 1598
2 S en3 ether 1500 1598
3 S en4 ether 1500 1598
4 S en5 ether 1500 1598
5 R br-local bridge 1500 1598
Ups! The filter has no effect!
That happens whenever the variable name ($name) matches the property
name (name=).
And another modification:
{ :local type "en1";
/ interface print where name=$type; }
And the result:
[admin@MikroTik] > { :local type "en1";
{... / interface print where name=$type; }
Flags: D - dynamic, X - disabled, R - running, S - slave
# NAME TYPE ACTUAL-MTU L2MTU
Ups! Nothing?
Even if the variable name ($type) matches whatever property name (type=)
things go wrong.
The answer from MikroTik support (in Ticket#2019010222000454):
> This is how scripting works in RouterOS and we will not fix it.
To get around this we use variable names in CamelCase. Let's hope
Mikrotik never ever introduces property names in CamelCase...
*fingers crossed*
| Christian Hesse | 1 | -5/+5 |
| 2019-01-02 | update copyright for 2019 | Christian Hesse | 1 | -1/+1 |
| 2018-11-09 | lease-script: use 'print count-only' | Christian Hesse | 1 | -1/+1 |
| 2018-10-09 | lease-script: line breaks for array | Christian Hesse | 1 | -3/+7 |
| 2018-09-27 | start scripts with a magic token / shebang | Christian Hesse | 1 | -1/+1 |
| 2018-08-24 | add empty comment at first line...•••... for better formatting in export.
| Christian Hesse | 1 | -0/+1 |
| 2018-07-11 | lease-script: fix typo | Christian Hesse | 1 | -1/+1 |
| 2018-07-09 | introduce templates for scripts depending on capsman or local wireless | Christian Hesse | 1 | -1/+3 |
| 2018-07-05 | add scripts | Christian Hesse | 1 | -0/+17 |
Christian Hesse