aboutsummaryrefslogtreecommitdiffstats
path: root/global-functions
AgeCommit message (Collapse)AuthorFilesLines
2019-01-04global: variable names are CamelCaseGravatar Christian Hesse1-58/+58
___ _ ___ __ / _ )(_)__ _ / _/__ _/ /_ / _ / / _ `/ / _/ _ `/ __/ /____/_/\_, / /_/ \_,_/\__/ _ __ /___/ _ __ | | / /___ __________ (_)___ ____ _/ / | | /| / / __ `/ ___/ __ \/ / __ \/ __ `/ / | |/ |/ / /_/ / / / / / / / / / / /_/ /_/ |__/|__/\__,_/_/ /_/ /_/_/_/ /_/\__, (_) /____/ RouterOS has some odd behavior when it comes to variable names. Let's have a look at the interfaces: [admin@MikroTik] > / interface print where name=en1 Flags: D - dynamic, X - disabled, R - running, S - slave # NAME TYPE ACTUAL-MTU L2MTU 0 RS en1 ether 1500 1598 That looks ok. Now we use a script: { :local interface "en1"; / interface print where name=$interface; } And the result... [admin@MikroTik] > { :local interface "en1"; {... / interface print where name=$interface; } Flags: D - dynamic, X - disabled, R - running, S - slave # NAME TYPE ACTUAL-MTU L2MTU 0 RS en1 ether 1500 1598 ... still looks ok. We make a little modification to the script: { :local name "en1"; / interface print where name=$name; } And the result: [admin@MikroTik] > { :local name "en1"; {... / interface print where name=$name; } Flags: D - dynamic, X - disabled, R - running, S - slave # NAME TYPE ACTUAL-MTU L2MTU 0 RS en1 ether 1500 1598 1 S en2 ether 1500 1598 2 S en3 ether 1500 1598 3 S en4 ether 1500 1598 4 S en5 ether 1500 1598 5 R br-local bridge 1500 1598 Ups! The filter has no effect! That happens whenever the variable name ($name) matches the property name (name=). And another modification: { :local type "en1"; / interface print where name=$type; } And the result: [admin@MikroTik] > { :local type "en1"; {... / interface print where name=$type; } Flags: D - dynamic, X - disabled, R - running, S - slave # NAME TYPE ACTUAL-MTU L2MTU Ups! Nothing? Even if the variable name ($type) matches whatever property name (type=) things go wrong. The answer from MikroTik support (in Ticket#2019010222000454): > This is how scripting works in RouterOS and we will not fix it. To get around this we use variable names in CamelCase. Let's hope Mikrotik never ever introduces property names in CamelCase... *fingers crossed*
2019-01-03global-{config,functions}: move variables, make independentGravatar Christian Hesse1-1/+6
2019-01-03script-updates: add configuration versioningGravatar Christian Hesse1-0/+3
2019-01-02update copyright for 2019Gravatar Christian Hesse1-1/+1
2018-12-28global-functions: properly define global functionsGravatar Christian Hesse1-0/+2
2018-12-28global-functions: update comment in $SendNotificationGravatar Christian Hesse1-1/+1
2018-12-28global-functions: add $DownloadPackageGravatar Christian Hesse1-0/+25
... and make script 'capsman-download-packages' use it.
2018-12-27global-functions: add $GetMacVendorGravatar Christian Hesse1-0/+15
2018-12-20global-functions: make $CertificateAvailable work on CommonNameGravatar Christian Hesse1-7/+8
This should prevent endless certificate switching for Let's Encrypt cross-signed intermediate certificates.
2018-12-12remove extra dollar signGravatar Christian Hesse1-2/+2
2018-11-28global-functions: add identity tag in $SendNotificationGravatar Christian Hesse1-2/+4
... and send subject in telegram message.
2018-11-09global-functions: use 'print count-only'Gravatar Christian Hesse1-1/+1
2018-11-09global-functions: add function to read user inputGravatar Christian Hesse1-0/+5
2018-10-16global-functions: import certificates if requiredGravatar Christian Hesse1-3/+24
Signed-off-by: Christian Hesse <mail@eworm.de>
2018-10-15global-functions: fix missing colonGravatar Christian Hesse1-2/+2
2018-10-12global-functions: make sure parameters are stringsGravatar Christian Hesse1-6/+7
2018-10-10daily-psk: move function GeneratePSK from global-functionsGravatar Christian Hesse1-42/+0
2018-10-09global-functions: add UrlEncode and use in SendNotificationGravatar Christian Hesse1-1/+25
2018-10-09global-functions: add function to notify via e-mail and telegramGravatar Christian Hesse1-0/+35
2018-10-09global-functions: move daily psk secrets to global-configGravatar Christian Hesse1-15/+4
2018-10-09make GeneratePSK a global functionGravatar Christian Hesse1-0/+52
2018-10-09add global-functionsGravatar Christian Hesse1-0/+6