Age | Commit message (Expand) | Author | Files | Lines |
2021-07-06 | collect-wireless-mac: rework, more use of arrays | Christian Hesse | 1 | -21/+17 |
2021-07-01 | collect-wireless-mac: properly handle vanished device | Christian Hesse | 1 | -6/+15 |
2021-07-01 | collect-wireless-mac: wait when locking script | Christian Hesse | 1 | -1/+1 |
2021-06-23 | lease-script: use 'provides' to find lease scripts | Christian Hesse | 1 | -0/+2 |
2021-04-28 | collect-wireless-mac: pass origin to $SendNotification2 | Christian Hesse | 1 | -1/+2 |
2021-04-28 | collect-wireless-mac: use $SendNotification2 | Christian Hesse | 1 | -4/+4 |
2021-02-24 | global: use $0 for $ScriptLock | Christian Hesse | 1 | -1/+1 |
2021-02-24 | global: give script or function name in log messages | Christian Hesse | 1 | -4/+5 |
2021-02-18 | global: drop script 'global-wait'•••All scripts wait for the global functions on their own now.
change-44 | Christian Hesse | 1 | -0/+3 |
2021-01-03 | collect-wireless-mac: always use first entry to place before | Christian Hesse | 1 | -1/+1 |
2021-01-01 | update copyright for 2021 | Christian Hesse | 1 | -1/+1 |
2020-12-30 | collect-wireless-mac: always select first lease from dhcp-server•••The script fails at setting the hostname when there are multiple leases
for a mac address.
In line 36 and 37 the hostname gets set from the data the lease. When there
is more than one lease for a specific mac address this fails with the message
"invalid internal item number". More than one lease for a mac address is
possible, if you have more than one SSID on a capsman and a single device
can login into more than one SSID.
Fixes #10
Signed-off-by: Christian Hesse <mail@eworm.de>
| Daniel Ziegenberg | 1 | -1/+1 |
2020-09-18 | collect-wireless-mac: add symbol in notification | Christian Hesse | 1 | -1/+2 |
2020-09-18 | extend magic pattern with "by RouterOS"•••This matches the string included in export.
| Christian Hesse | 1 | -1/+1 |
2020-08-26 | [ ... print count-only ...] -> [ :len [ ... find ... ] ]•••Using 'print count-only' always prints a number to terminal, even if the
value is evaluated in a condition or assigned to a variable. This can be
quite annoying. Behavior will not chance (SUP-25503), so replacing the
code...
| Christian Hesse | 1 | -1/+1 |
2020-06-19 | explicitly name the license•••Copyright (C) 2013-2020 Christian Hesse <mail@eworm.de>
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
https://www.gnu.org/licenses/#GPL
https://www.gnu.org/licenses/gpl.html
https://www.gnu.org/licenses/gpl.md
| Christian Hesse | 1 | -0/+1 |
2020-03-27 | add doc/collect-wireless-mac.md | Christian Hesse | 1 | -0/+1 |
2020-03-05 | always use severity 'warning', not just 'warn' | Christian Hesse | 1 | -1/+1 |
2020-03-05 | collect-wireless-mac: use $LogPrintExit | Christian Hesse | 1 | -4/+5 |
2020-02-28 | global-functions: sort alphabetically | Christian Hesse | 1 | -1/+1 |
2020-01-17 | collect-wireless-mac: automatically add missing access-list entry | Christian Hesse | 1 | -4/+4 |
2020-01-06 | collect-wireless-mac: use dynamic & bound mac address only | Christian Hesse | 1 | -1/+1 |
2020-01-01 | update copyright for 2020 | Christian Hesse | 1 | -1/+1 |
2019-11-25 | collect-wireless-mac: add the dns name | Christian Hesse | 1 | -0/+6 |
2019-11-25 | collect-wireless-mac: lease without address should be impossible...•••... we need the check for empty hostname, though.
| Christian Hesse | 1 | -5/+2 |
2019-11-25 | collect-wireless-mac: move code into condition | Christian Hesse | 1 | -6/+6 |
2019-04-03 | always write warnings and errors to log | Christian Hesse | 1 | -1/+2 |
2019-02-21 | collect-wireless-mac: use $ScriptLock | Christian Hesse | 1 | -0/+3 |
2019-01-15 | collect-wireless-mac: simplify array access | Christian Hesse | 1 | -1/+1 |
2019-01-04 | global: variable names are CamelCase••• ___ _ ___ __
/ _ )(_)__ _ / _/__ _/ /_
/ _ / / _ `/ / _/ _ `/ __/
/____/_/\_, / /_/ \_,_/\__/
_ __ /___/ _ __
| | / /___ __________ (_)___ ____ _/ /
| | /| / / __ `/ ___/ __ \/ / __ \/ __ `/ /
| |/ |/ / /_/ / / / / / / / / / / /_/ /_/
|__/|__/\__,_/_/ /_/ /_/_/_/ /_/\__, (_)
/____/
RouterOS has some odd behavior when it comes to variable names. Let's
have a look at the interfaces:
[admin@MikroTik] > / interface print where name=en1
Flags: D - dynamic, X - disabled, R - running, S - slave
# NAME TYPE ACTUAL-MTU L2MTU
0 RS en1 ether 1500 1598
That looks ok. Now we use a script:
{ :local interface "en1";
/ interface print where name=$interface; }
And the result...
[admin@MikroTik] > { :local interface "en1";
{... / interface print where name=$interface; }
Flags: D - dynamic, X - disabled, R - running, S - slave
# NAME TYPE ACTUAL-MTU L2MTU
0 RS en1 ether 1500 1598
... still looks ok.
We make a little modification to the script:
{ :local name "en1";
/ interface print where name=$name; }
And the result:
[admin@MikroTik] > { :local name "en1";
{... / interface print where name=$name; }
Flags: D - dynamic, X - disabled, R - running, S - slave
# NAME TYPE ACTUAL-MTU L2MTU
0 RS en1 ether 1500 1598
1 S en2 ether 1500 1598
2 S en3 ether 1500 1598
3 S en4 ether 1500 1598
4 S en5 ether 1500 1598
5 R br-local bridge 1500 1598
Ups! The filter has no effect!
That happens whenever the variable name ($name) matches the property
name (name=).
And another modification:
{ :local type "en1";
/ interface print where name=$type; }
And the result:
[admin@MikroTik] > { :local type "en1";
{... / interface print where name=$type; }
Flags: D - dynamic, X - disabled, R - running, S - slave
# NAME TYPE ACTUAL-MTU L2MTU
Ups! Nothing?
Even if the variable name ($type) matches whatever property name (type=)
things go wrong.
The answer from MikroTik support (in Ticket#2019010222000454):
> This is how scripting works in RouterOS and we will not fix it.
To get around this we use variable names in CamelCase. Let's hope
Mikrotik never ever introduces property names in CamelCase...
*fingers crossed*
| Christian Hesse | 1 | -39/+39 |
2019-01-02 | update copyright for 2019 | Christian Hesse | 1 | -1/+1 |
2018-12-28 | global-functions: properly define global functions | Christian Hesse | 1 | -1/+0 |
2018-12-27 | global-functions: add $GetMacVendor | Christian Hesse | 1 | -8/+2 |
2018-12-20 | global-functions: make $CertificateAvailable work on CommonName•••This should prevent endless certificate switching for Let's Encrypt
cross-signed intermediate certificates.
| Christian Hesse | 1 | -1/+1 |
2018-12-14 | collect-wireless-mac: send the mac's vendor part only | Christian Hesse | 1 | -1/+1 |
2018-12-14 | collect-wireless-mac: get and record the vendor | Christian Hesse | 1 | -2/+12 |
2018-11-28 | global-functions: add identity tag in $SendNotification•••... and send subject in telegram message.
| Christian Hesse | 1 | -1/+1 |
2018-10-10 | global: remove unused variables | Christian Hesse | 1 | -2/+0 |
2018-10-09 | collect-wireless-mac: use function for notification | Christian Hesse | 1 | -3/+4 |
2018-09-27 | start scripts with a magic token / shebang | Christian Hesse | 1 | -1/+1 |
2018-08-24 | add empty comment at first line...•••... for better formatting in export.
| Christian Hesse | 1 | -0/+1 |
2018-07-10 | update template system | Christian Hesse | 1 | -0/+58 |