aboutsummaryrefslogtreecommitdiffstats
path: root/collect-wireless-mac.capsman
AgeCommit message (Collapse)AuthorFilesLines
2020-12-30collect-wireless-mac: always select first lease from dhcp-serverGravatar Daniel Ziegenberg1-1/+1
The script fails at setting the hostname when there are multiple leases for a mac address. In line 36 and 37 the hostname gets set from the data the lease. When there is more than one lease for a specific mac address this fails with the message "invalid internal item number". More than one lease for a mac address is possible, if you have more than one SSID on a capsman and a single device can login into more than one SSID. Fixes #10 Signed-off-by: Christian Hesse <mail@eworm.de>
2020-09-18collect-wireless-mac: add symbol in notificationGravatar Christian Hesse1-1/+2
2020-09-18extend magic pattern with "by RouterOS"Gravatar Christian Hesse1-1/+1
This matches the string included in export.
2020-08-26[ ... print count-only ...] -> [ :len [ ... find ... ] ]Gravatar Christian Hesse1-1/+1
Using 'print count-only' always prints a number to terminal, even if the value is evaluated in a condition or assigned to a variable. This can be quite annoying. Behavior will not chance (SUP-25503), so replacing the code...
2020-06-19explicitly name the licenseGravatar Christian Hesse1-0/+1
Copyright (C) 2013-2020 Christian Hesse <mail@eworm.de> This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. https://www.gnu.org/licenses/#GPL https://www.gnu.org/licenses/gpl.html https://www.gnu.org/licenses/gpl.md
2020-03-27add doc/collect-wireless-mac.mdGravatar Christian Hesse1-0/+1
2020-03-05always use severity 'warning', not just 'warn'Gravatar Christian Hesse1-1/+1
2020-03-05collect-wireless-mac: use $LogPrintExitGravatar Christian Hesse1-4/+5
2020-02-28global-functions: sort alphabeticallyGravatar Christian Hesse1-1/+1
2020-01-17collect-wireless-mac: automatically add missing access-list entryGravatar Christian Hesse1-4/+4
2020-01-06collect-wireless-mac: use dynamic & bound mac address onlyGravatar Christian Hesse1-1/+1
2020-01-01update copyright for 2020Gravatar Christian Hesse1-1/+1
2019-11-25collect-wireless-mac: add the dns nameGravatar Christian Hesse1-0/+6
2019-11-25collect-wireless-mac: lease without address should be impossible...Gravatar Christian Hesse1-5/+2
... we need the check for empty hostname, though.
2019-11-25collect-wireless-mac: move code into conditionGravatar Christian Hesse1-6/+6
2019-04-03always write warnings and errors to logGravatar Christian Hesse1-1/+2
2019-02-21collect-wireless-mac: use $ScriptLockGravatar Christian Hesse1-0/+3
2019-01-15collect-wireless-mac: simplify array accessGravatar Christian Hesse1-1/+1
2019-01-04global: variable names are CamelCaseGravatar Christian Hesse1-38/+38
___ _ ___ __ / _ )(_)__ _ / _/__ _/ /_ / _ / / _ `/ / _/ _ `/ __/ /____/_/\_, / /_/ \_,_/\__/ _ __ /___/ _ __ | | / /___ __________ (_)___ ____ _/ / | | /| / / __ `/ ___/ __ \/ / __ \/ __ `/ / | |/ |/ / /_/ / / / / / / / / / / /_/ /_/ |__/|__/\__,_/_/ /_/ /_/_/_/ /_/\__, (_) /____/ RouterOS has some odd behavior when it comes to variable names. Let's have a look at the interfaces: [admin@MikroTik] > / interface print where name=en1 Flags: D - dynamic, X - disabled, R - running, S - slave # NAME TYPE ACTUAL-MTU L2MTU 0 RS en1 ether 1500 1598 That looks ok. Now we use a script: { :local interface "en1"; / interface print where name=$interface; } And the result... [admin@MikroTik] > { :local interface "en1"; {... / interface print where name=$interface; } Flags: D - dynamic, X - disabled, R - running, S - slave # NAME TYPE ACTUAL-MTU L2MTU 0 RS en1 ether 1500 1598 ... still looks ok. We make a little modification to the script: { :local name "en1"; / interface print where name=$name; } And the result: [admin@MikroTik] > { :local name "en1"; {... / interface print where name=$name; } Flags: D - dynamic, X - disabled, R - running, S - slave # NAME TYPE ACTUAL-MTU L2MTU 0 RS en1 ether 1500 1598 1 S en2 ether 1500 1598 2 S en3 ether 1500 1598 3 S en4 ether 1500 1598 4 S en5 ether 1500 1598 5 R br-local bridge 1500 1598 Ups! The filter has no effect! That happens whenever the variable name ($name) matches the property name (name=). And another modification: { :local type "en1"; / interface print where name=$type; } And the result: [admin@MikroTik] > { :local type "en1"; {... / interface print where name=$type; } Flags: D - dynamic, X - disabled, R - running, S - slave # NAME TYPE ACTUAL-MTU L2MTU Ups! Nothing? Even if the variable name ($type) matches whatever property name (type=) things go wrong. The answer from MikroTik support (in Ticket#2019010222000454): > This is how scripting works in RouterOS and we will not fix it. To get around this we use variable names in CamelCase. Let's hope Mikrotik never ever introduces property names in CamelCase... *fingers crossed*
2019-01-02update copyright for 2019Gravatar Christian Hesse1-1/+1
2018-12-28global-functions: properly define global functionsGravatar Christian Hesse1-1/+0
2018-12-27global-functions: add $GetMacVendorGravatar Christian Hesse1-8/+2
2018-12-20global-functions: make $CertificateAvailable work on CommonNameGravatar Christian Hesse1-1/+1
This should prevent endless certificate switching for Let's Encrypt cross-signed intermediate certificates.
2018-12-14collect-wireless-mac: send the mac's vendor part onlyGravatar Christian Hesse1-1/+1
2018-12-14collect-wireless-mac: get and record the vendorGravatar Christian Hesse1-2/+12
2018-11-28global-functions: add identity tag in $SendNotificationGravatar Christian Hesse1-1/+1
... and send subject in telegram message.
2018-10-10global: remove unused variablesGravatar Christian Hesse1-2/+0
2018-10-09collect-wireless-mac: use function for notificationGravatar Christian Hesse1-3/+4
2018-09-27start scripts with a magic token / shebangGravatar Christian Hesse1-1/+1
2018-08-24add empty comment at first line...Gravatar Christian Hesse1-0/+1
... for better formatting in export.
2018-07-10update template systemGravatar Christian Hesse1-8/+2
2018-07-09introduce templates for scripts depending on capsman or local wirelessGravatar Christian Hesse1-0/+62