Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2022-03-30 | check-lte-firmware-upgrade: be more verbose | 1 | -1/+8 | ||
(cherry picked from commit 5aecc9f1a316874f9c2935b6065347223927a299) | |||||
2022-01-01 | update copyright for 2022 | 1 | -1/+1 | ||
2021-04-28 | check-lte-firmware-upgrade: pass origin to $SendNotification2 | 1 | -1/+2 | ||
2021-04-28 | check-lte-firmware-upgrade: use $SendNotification2 | 1 | -7/+7 | ||
2021-02-24 | global: give script or function name in log messages | 1 | -3/+4 | ||
2021-02-18 | global: drop script 'global-wait'change-44 | 1 | -0/+3 | ||
All scripts wait for the global functions on their own now. | |||||
2021-02-16 | global-functions: drop support for attachment in notification e-mail | 1 | -1/+1 | ||
2021-01-01 | update copyright for 2021 | 1 | -1/+1 | ||
2020-11-26 | global-functions: clickable links in telegram notifications | 1 | -1/+1 | ||
2020-10-13 | check-lte-firmware-upgrade: show manufacturer & model | 1 | -0/+3 | ||
2020-09-18 | extend magic pattern with "by RouterOS" | 1 | -1/+1 | ||
This matches the string included in export. | |||||
2020-07-17 | check-lte-firmware-upgrade: add symbol in notification | 1 | -1/+2 | ||
2020-06-19 | explicitly name the license | 1 | -0/+1 | ||
Copyright (C) 2013-2020 Christian Hesse <mail@eworm.de> This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. https://www.gnu.org/licenses/#GPL https://www.gnu.org/licenses/gpl.html https://www.gnu.org/licenses/gpl.md | |||||
2020-04-07 | check-lte-firmware-upgrade: give current and available version | 1 | -1/+3 | ||
2020-04-03 | check-lte-firmware-upgrade: use $LogPrintExit | 1 | -4/+5 | ||
2020-03-27 | add doc/check-lte-firmware-upgrade.md | 1 | -1/+2 | ||
2020-01-01 | update copyright for 2020 | 1 | -1/+1 | ||
2019-08-18 | check-lte-firmware-upgrade: make notification silent | 1 | -1/+1 | ||
2019-05-23 | check-lte-firmware-upgrade: drop literal 'notification' | 1 | -2/+2 | ||
2019-02-11 | check-lte-firmware-upgrade: remove workaroundrouteros-6.44beta75-1 | 1 | -2/+0 | ||
This is fixed in 6.44beta75. | |||||
2019-01-04 | global: variable names are CamelCase | 1 | -13/+13 | ||
___ _ ___ __ / _ )(_)__ _ / _/__ _/ /_ / _ / / _ `/ / _/ _ `/ __/ /____/_/\_, / /_/ \_,_/\__/ _ __ /___/ _ __ | | / /___ __________ (_)___ ____ _/ / | | /| / / __ `/ ___/ __ \/ / __ \/ __ `/ / | |/ |/ / /_/ / / / / / / / / / / /_/ /_/ |__/|__/\__,_/_/ /_/ /_/_/_/ /_/\__, (_) /____/ RouterOS has some odd behavior when it comes to variable names. Let's have a look at the interfaces: [admin@MikroTik] > / interface print where name=en1 Flags: D - dynamic, X - disabled, R - running, S - slave # NAME TYPE ACTUAL-MTU L2MTU 0 RS en1 ether 1500 1598 That looks ok. Now we use a script: { :local interface "en1"; / interface print where name=$interface; } And the result... [admin@MikroTik] > { :local interface "en1"; {... / interface print where name=$interface; } Flags: D - dynamic, X - disabled, R - running, S - slave # NAME TYPE ACTUAL-MTU L2MTU 0 RS en1 ether 1500 1598 ... still looks ok. We make a little modification to the script: { :local name "en1"; / interface print where name=$name; } And the result: [admin@MikroTik] > { :local name "en1"; {... / interface print where name=$name; } Flags: D - dynamic, X - disabled, R - running, S - slave # NAME TYPE ACTUAL-MTU L2MTU 0 RS en1 ether 1500 1598 1 S en2 ether 1500 1598 2 S en3 ether 1500 1598 3 S en4 ether 1500 1598 4 S en5 ether 1500 1598 5 R br-local bridge 1500 1598 Ups! The filter has no effect! That happens whenever the variable name ($name) matches the property name (name=). And another modification: { :local type "en1"; / interface print where name=$type; } And the result: [admin@MikroTik] > { :local type "en1"; {... / interface print where name=$type; } Flags: D - dynamic, X - disabled, R - running, S - slave # NAME TYPE ACTUAL-MTU L2MTU Ups! Nothing? Even if the variable name ($type) matches whatever property name (type=) things go wrong. The answer from MikroTik support (in Ticket#2019010222000454): > This is how scripting works in RouterOS and we will not fix it. To get around this we use variable names in CamelCase. Let's hope Mikrotik never ever introduces property names in CamelCase... *fingers crossed* | |||||
2019-01-02 | rename script 'check-lte-firmware-update' -> 'check-lte-firmware-upgrade' | 1 | -0/+34 | ||
That's the correct wording from commands.. |