Age | Commit message (Expand) | Author | Files | Lines |
2019-01-04 | global: variable names are CamelCase••• ___ _ ___ __
/ _ )(_)__ _ / _/__ _/ /_
/ _ / / _ `/ / _/ _ `/ __/
/____/_/\_, / /_/ \_,_/\__/
_ __ /___/ _ __
| | / /___ __________ (_)___ ____ _/ /
| | /| / / __ `/ ___/ __ \/ / __ \/ __ `/ /
| |/ |/ / /_/ / / / / / / / / / / /_/ /_/
|__/|__/\__,_/_/ /_/ /_/_/_/ /_/\__, (_)
/____/
RouterOS has some odd behavior when it comes to variable names. Let's
have a look at the interfaces:
[admin@MikroTik] > / interface print where name=en1
Flags: D - dynamic, X - disabled, R - running, S - slave
# NAME TYPE ACTUAL-MTU L2MTU
0 RS en1 ether 1500 1598
That looks ok. Now we use a script:
{ :local interface "en1";
/ interface print where name=$interface; }
And the result...
[admin@MikroTik] > { :local interface "en1";
{... / interface print where name=$interface; }
Flags: D - dynamic, X - disabled, R - running, S - slave
# NAME TYPE ACTUAL-MTU L2MTU
0 RS en1 ether 1500 1598
... still looks ok.
We make a little modification to the script:
{ :local name "en1";
/ interface print where name=$name; }
And the result:
[admin@MikroTik] > { :local name "en1";
{... / interface print where name=$name; }
Flags: D - dynamic, X - disabled, R - running, S - slave
# NAME TYPE ACTUAL-MTU L2MTU
0 RS en1 ether 1500 1598
1 S en2 ether 1500 1598
2 S en3 ether 1500 1598
3 S en4 ether 1500 1598
4 S en5 ether 1500 1598
5 R br-local bridge 1500 1598
Ups! The filter has no effect!
That happens whenever the variable name ($name) matches the property
name (name=).
And another modification:
{ :local type "en1";
/ interface print where name=$type; }
And the result:
[admin@MikroTik] > { :local type "en1";
{... / interface print where name=$type; }
Flags: D - dynamic, X - disabled, R - running, S - slave
# NAME TYPE ACTUAL-MTU L2MTU
Ups! Nothing?
Even if the variable name ($type) matches whatever property name (type=)
things go wrong.
The answer from MikroTik support (in Ticket#2019010222000454):
> This is how scripting works in RouterOS and we will not fix it.
To get around this we use variable names in CamelCase. Let's hope
Mikrotik never ever introduces property names in CamelCase...
*fingers crossed*
| Christian Hesse | 41 | -782/+775 |
2019-01-03 | global-{config,functions}: move variables, make independent | Christian Hesse | 4 | -9/+12 |
2019-01-03 | script-updates: add configuration versioning | Christian Hesse | 3 | -0/+20 |
2019-01-03 | dhcp-to-dns: give time in short format•••Note that a unit is required to make it a time value!
| Christian Hesse | 1 | -1/+1 |
2019-01-03 | daily-psk-schedule: give time in short format•••Note that a unit is required to make it a time value!
| Christian Hesse | 1 | -1/+1 |
2019-01-02 | rename script 'check-lte-firmware-update' -> 'check-lte-firmware-upgrade'•••That's the correct wording from commands..
| Christian Hesse | 2 | -8/+8 |
2019-01-02 | add script 'unattended-lte-firmware-upgrade' | Christian Hesse | 1 | -0/+29 |
2019-01-02 | add template for script documentation | Christian Hesse | 1 | -0/+47 |
2019-01-02 | README: add link to scroll up | Christian Hesse | 1 | -0/+2 |
2019-01-02 | ignore all html files | Christian Hesse | 1 | -1/+1 |
2019-01-02 | Makefile: update links for generated html | Christian Hesse | 1 | -1/+1 |
2019-01-02 | Makefile: update for extended functionality•••This can handle new and multiple markdown files.
| Christian Hesse | 1 | -8/+17 |
2019-01-02 | update-tunnelbroker: verify certificate | Christian Hesse | 2 | -2/+58 |
2019-01-02 | update-tunnelbroker: move configuration to global-config...•••... and get the external ip address from cloud.
Signed-off-by: Michael Gisbers <michael@gisbers.de>
Signed-off-by: Christian Hesse <mail@eworm.de>
| Michael Gisbers | 2 | -19/+28 |
2019-01-02 | capsman-download-packages: use upgrade command to force remote-cap upgrade•••Signed-off-by: Michael Gisbers <michael@gisbers.de>
Signed-off-by: Christian Hesse <mail@eworm.de>
| Michael Gisbers | 1 | -1/+1 |
2019-01-02 | check-routeros-update: be more verbose on error | Christian Hesse | 1 | -1/+1 |
2019-01-02 | check-routeros-update: do not fail if safe-update-url return error•••We still want the notification...
| Christian Hesse | 1 | -6/+11 |
2019-01-02 | update copyright for 2019 | Christian Hesse | 43 | -44/+44 |
2018-12-28 | global-functions: properly define global functions | Christian Hesse | 4 | -3/+2 |
2018-12-28 | global-functions: update comment in $SendNotification | Christian Hesse | 1 | -1/+1 |
2018-12-28 | global-functions: add $DownloadPackage•••... and make script 'capsman-download-packages' use it.
| Christian Hesse | 2 | -8/+30 |
2018-12-28 | capsman-download-packages: move condition to loop | Christian Hesse | 1 | -17/+16 |
2018-12-27 | remove script 'remove-packages'•••Use script 'capsman-download-packages' to download and
cleanup packages...
| Christian Hesse | 1 | -19/+0 |
2018-12-27 | capsman-download-packages: act in package-path only | Christian Hesse | 1 | -1/+4 |
2018-12-27 | capsman-download-packages: do not restart service...•••... but disconnect old CAPs and force reconnect with update.
| Christian Hesse | 1 | -2/+2 |
2018-12-27 | capsman-download-packages: rewrite package-name from wireless@ to wireless•••Signed-off-by: Michael Gisbers <michael@gisbers.de>
Signed-off-by: Christian Hesse <mail@eworm.de>
| Michael Gisbers | 1 | -0/+4 |
2018-12-27 | add script 'capsman-download-packages' | Christian Hesse | 1 | -0/+34 |
2018-12-27 | global-functions: add $GetMacVendor | Christian Hesse | 4 | -24/+21 |
2018-12-21 | remove-packages: delay if uptime less than one minute | Christian Hesse | 1 | -0/+2 |
2018-12-20 | global-functions: make $CertificateAvailable work on CommonName•••This should prevent endless certificate switching for Let's Encrypt
cross-signed intermediate certificates.
| Christian Hesse | 10 | -148/+147 |
2018-12-20 | README: add Root CA certificate DST Root CA X3•••This is used by Let's Encrypt to cross-sign.
| Christian Hesse | 3 | -5/+34 |
2018-12-20 | check-certificates: support auto-renew of certificates | Christian Hesse | 2 | -10/+49 |
2018-12-19 | update-gre-address: remove settings from global-config•••Instead read infos from gre interface comment.
| Christian Hesse | 2 | -21/+9 |
2018-12-19 | ipv6-update: remove settings from global-config•••Instead make it more robust by reading comments.
| Christian Hesse | 2 | -21/+12 |
2018-12-18 | email-backup: support cloud backup | Christian Hesse | 2 | -7/+30 |
2018-12-18 | README: add initial commands for copy and paste | Christian Hesse | 2 | -0/+28 |
2018-12-17 | check-lte-firmware-update: strip the extra line break | Christian Hesse | 1 | -0/+2 |
2018-12-14 | add script 'check-lte-firmware-update' | Christian Hesse | 2 | -0/+33 |
2018-12-14 | collect-wireless-mac: send the mac's vendor part only | Christian Hesse | 3 | -3/+3 |
2018-12-14 | collect-wireless-mac: get and record the vendor | Christian Hesse | 3 | -6/+36 |
2018-12-13 | email-backup: try without delay | Christian Hesse | 1 | -2/+0 |
2018-12-12 | remove extra dollar sign | Christian Hesse | 5 | -9/+9 |
2018-12-12 | email-backup: send backup and config export in one mail | Christian Hesse | 1 | -20/+23 |
2018-12-12 | email-backup: export terse | Christian Hesse | 1 | -2/+2 |
2018-11-28 | global-functions: add identity tag in $SendNotification•••... and send subject in telegram message.
| Christian Hesse | 9 | -11/+13 |
2018-11-26 | global-config: add identity tag | Christian Hesse | 1 | -1/+1 |
2018-11-26 | ip-addr-bridge: ignore bridges without ports•••Bridges are used for loopback... Assume we do not want to disable
addresses if the bridge has no ports.
| Christian Hesse | 1 | -4/+6 |
2018-11-13 | global-config: sort sms-action alphabetically | Christian Hesse | 1 | -2/+2 |
2018-11-13 | global-config: add more examples for mode button and sms-action | Christian Hesse | 1 | -3/+5 |
2018-11-09 | global-functions: use 'print count-only' | Christian Hesse | 1 | -1/+1 |
2018-11-09 | check-routeros-update: use 'print count-only' | Christian Hesse | 1 | -1/+1 |
2018-11-09 | learn-mac-based-vlan: move log inside condition | Christian Hesse | 1 | -3/+2 |
2018-11-09 | learn-mac-based-vlan: use 'print count-only' | Christian Hesse | 1 | -1/+1 |
2018-11-09 | dhcp-to-dns: use 'print count-only' | Christian Hesse | 1 | -1/+1 |
2018-11-09 | lease-script: use 'print count-only' | Christian Hesse | 1 | -1/+1 |
2018-11-09 | add script 'ip-addr-bridge' | Christian Hesse | 1 | -0/+14 |
2018-11-09 | accesslist-duplicates: support interactive removal | Christian Hesse | 3 | -0/+27 |
2018-11-09 | global-functions: add function to read user input | Christian Hesse | 1 | -0/+5 |
2018-10-25 | bridge-port-to-default: delay only when required | Christian Hesse | 1 | -3/+5 |
2018-10-25 | bridge-port-to-default: delay for global-config•••All scripts scheduled with "start-time=startup interval=0" start
simultaneously, thus racing on global variables. So delay for
a second and give global-config time to finish.
| Christian Hesse | 1 | -0/+3 |
2018-10-25 | bridge-port-to-default: drop unused code, :toarray strips itself | Christian Hesse | 1 | -3/+0 |
2018-10-25 | bridge-port-to-default: fix variable name | Christian Hesse | 1 | -1/+1 |
2018-10-16 | script-updates: run global-functions on update | Christian Hesse | 1 | -0/+3 |
2018-10-16 | README: do not print the certificates but count them | Christian Hesse | 1 | -5/+4 |
2018-10-16 | README: download certificates from repository | Christian Hesse | 3 | -18/+69 |
2018-10-16 | global-functions: import certificates if required•••Signed-off-by: Christian Hesse <mail@eworm.de>
| Christian Hesse | 3 | -3/+76 |
2018-10-15 | daily-psk: add error handling for fetch | Christian Hesse | 1 | -4/+9 |
2018-10-15 | global-functions: fix missing colon | Christian Hesse | 1 | -2/+2 |
2018-10-12 | global-functions: make sure parameters are strings | Christian Hesse | 1 | -6/+7 |
2018-10-12 | add script 'daily-psk-schedule' | Christian Hesse | 2 | -12/+23 |
2018-10-12 | netwatch-syslog: set dont-require-permissions=yes•••... and drop the scheduler workaround.
| Christian Hesse | 1 | -2/+2 |
2018-10-12 | script-updates: allow to set dont-require-permissions=yes•••This requires the new script to contain a line:
# requires: dont-require-permissions=yes
| Christian Hesse | 1 | -1/+4 |
2018-10-11 | mode-button-event: decrease interval, but update start time | Christian Hesse | 1 | -3/+8 |
2018-10-10 | global: remove unused variables | Christian Hesse | 7 | -14/+0 |
2018-10-10 | daily-psk: merge with email-daily-psk | Christian Hesse | 2 | -68/+44 |
2018-10-10 | daily-psk: move function GeneratePSK from global-functions | Christian Hesse | 2 | -43/+41 |
2018-10-10 | check-routeros-update: send notification on auto-update | Christian Hesse | 1 | -0/+3 |
2018-10-10 | global-config: default for telegram is empty strings...•••... to make sure the api is not flooded with invalid requests.
| Christian Hesse | 1 | -2/+4 |
2018-10-09 | README: now that we need three scripts... download and add in loop | Christian Hesse | 1 | -3/+1 |
2018-10-09 | global-functions: add UrlEncode and use in SendNotification | Christian Hesse | 1 | -1/+25 |
2018-10-09 | sms-forward: use function for notification | Christian Hesse | 1 | -3/+4 |
2018-10-09 | check-routeros-update: use function for notification | Christian Hesse | 1 | -3/+4 |
2018-10-09 | check-certificates: use function for notification | Christian Hesse | 1 | -3/+4 |
2018-10-09 | collect-wireless-mac: use function for notification | Christian Hesse | 3 | -9/+12 |
2018-10-09 | email-daily-psk: use function for notification | Christian Hesse | 1 | -4/+5 |
2018-10-09 | global-functions: add function to notify via e-mail and telegram | Christian Hesse | 2 | -0/+40 |
2018-10-09 | global-functions: move daily psk secrets to global-config | Christian Hesse | 2 | -17/+20 |
2018-10-09 | make GeneratePSK a global function | Christian Hesse | 4 | -55/+59 |
2018-10-09 | add global-functions | Christian Hesse | 3 | -0/+8 |
2018-10-09 | lease-script: line breaks for array | Christian Hesse | 1 | -3/+7 |
2018-10-04 | bridge-port-to-default: strip leading blank from comment | Christian Hesse | 1 | -0/+3 |
2018-10-04 | add script 'bridge-port-toggle'•••... to toggle between configuration 'default' and 'alt'.
| Christian Hesse | 2 | -0/+16 |
2018-10-04 | bridge-port-to-default: support different configurations•••Just add something like this to your bridge ports:
comment="default:br-ext,alt:br-intern"
| Christian Hesse | 2 | -10/+21 |
2018-10-04 | global-config: add missing semicolons | Christian Hesse | 1 | -5/+5 |
2018-09-28 | script-updates: make sure new script starts with magic | Christian Hesse | 1 | -5/+9 |
2018-09-27 | start scripts with a magic token / shebang | Christian Hesse | 39 | -39/+39 |
2018-09-23 | sms-forward: make handling of SMS with action more robust | Christian Hesse | 1 | -9/+17 |
2018-09-20 | check-routeros-update: add missing space, break line | Christian Hesse | 1 | -1/+2 |
2018-09-19 | check-routeros-update: send versions to safe-update-url | Christian Hesse | 1 | -1/+2 |
2018-09-18 | rotate-ntp: warn if ntp client is disabled | Christian Hesse | 1 | -0/+4 |